Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the windows binary release format to .zip #378

Merged
merged 1 commit into from
Oct 27, 2020
Merged

change the windows binary release format to .zip #378

merged 1 commit into from
Oct 27, 2020

Conversation

chanwit
Copy link
Contributor

@chanwit chanwit commented Oct 27, 2020

This PR changes the Windows binary release format from .tar.gz to .zip.

@hiddeco hiddeco added the area/ci CI related issues and pull requests label Oct 27, 2020
goarch:
- amd64
- arm64
- arm
goarm:
- 7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this produces v6 binaries and that breaks ARMv7 compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad. it's a mistake.

Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @chanwit 🍰

@stefanprodan stefanprodan merged commit f72b323 into fluxcd:main Oct 27, 2020
@chanwit chanwit deleted the windows-zip branch October 30, 2020 12:36
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants