Add support for HelmRepo OCI and NC v1beta3 static objects #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
749931e to
b324d32
Compare
This was referenced Oct 5, 2023
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
b324d32 to
0f928ed
Compare
darkowlzz
force-pushed
the
kstatus-readiness
branch
from
e13ab33 to
ec73c24
Compare
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
0f928ed to
9a3e345
Compare
darkowlzz
force-pushed
the
kstatus-readiness
branch
2 times, most recently
from
25a8559 to
c75cdc3
Compare
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
9a3e345 to
112a94f
Compare
darkowlzz
force-pushed
the
kstatus-readiness
branch
from
c75cdc3 to
db708de
Compare
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
112a94f to
f2ec1ad
Compare
darkowlzz
force-pushed
the
kstatus-readiness
branch
from
db708de to
96559e4
Compare
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
f2ec1ad to
c004099
Compare
darkowlzz
changed the title
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
5b46a05 to
1d9feae
Compare
darkowlzz
commented
Nov 28, 2023
darkowlzz
force-pushed
the
kstatus-readiness
branch
2 times, most recently
from
cd61094 to
720396c
Compare
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
4 times, most recently
from
8265de6 to
b7ff3eb
Compare
darkowlzz
force-pushed
the
kstatus-readiness
branch
from
720396c to
05c13fe
Compare
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
2 times, most recently
from
936db5f to
56e035d
Compare
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
2 times, most recently
from
a1bc966 to
7b904f6
Compare
aryan9600
reviewed
Dec 8, 2023
Remove reconcile subcommand for static object APIs Alerts and Providers. Add a isStatic() method on all the object adapters to determine if they are static and don't have reconciler. The objects that don't have reconcilers are skipped from reconciliation and readiness checks like HelmRepository of type OCI. Add default ready message for `get` subcommand output for static objects, Alerts, Providers and HelmRepositories of type OCI, as ready message can't be derived for them from their status. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
HelmRepo OCI, Alerts and Providers are static objects and don't need to be checked for readiness. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
no-reconcile-ready-static
branch
from
7b904f6 to
2649bfb
Compare
darkowlzz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on fluxcd/notification-controller#540 and fluxcd/source-controller#1243 that make HelmRepository OCI, Alert and Provider static objects.
This change makes the CLI aware of static objects. Static objects don't have status to report readiness. The CLI shows them as ready always.
fluxcd/source-controller#1243 makes HelmRepository OCI static. CLI shows it as ready:
The static objects also don't support reconciliation. The CLI prints that the objects don't support reconciliation.
alertandalert-providersubcommands forreconcilehave been removed as they are completely static objects in Alert and Provider v1beta3 API.Update all the references of NC v1beta2 API to v1beta3 and updates the tests accordingly.
flux2 GCP e2e test run with these changes https://github.com/fluxcd/flux2/actions/runs/7142695935/job/19452536537.