Align name of release files for easier consumption #30
Conversation
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
.github/workflows/release.yaml
Outdated
|
|
||
| libtool -static -o ./libgit2-darwin-libgit2-all/lib/libcrypto.a \ | ||
| ${GITHUB_WORKSPACE}/build/libgit2-darwin-amd64/lib/libcrypto.a \ | ||
| LIBGIT2_SED="s;-L/Applications/Xcode_.* ;;g" |
There was a problem hiding this comment.
Shouldn't this be?
| LIBGIT2_SED="s;-L/Applications/Xcode_.* ;;g" | |
| LIBGIT2_SED="s;-L/Applications/Xcode.* ;;g" |
Also, we should be doing this when we are building libgit2 only as well? This is what libgit2.pc looks like on my mac (running macOS 12) when I build libgit2 only:
prefix="/Users/sanskarjaiswal/Development/fluxcd/golang-with-libgit2/build/libgit2"
libdir="/Users/sanskarjaiswal/Development/fluxcd/golang-with-libgit2/build/libgit2/lib"
includedir="/Users/sanskarjaiswal/Development/fluxcd/golang-with-libgit2/build/libgit2/include"
Name: libgit2
Description: The git library, take 2
Version: 1.3.1
Libs: -L${libdir} -lgit2
Libs.private: -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/lib -liconv
Cflags: -I${includedir}
There was a problem hiding this comment.
This was extracted from the script we currently run at both IAC and SC and is based on the current runner's OS:
https://github.com/fluxcd/source-controller/blob/main/hack/install-libraries.sh#L59
I updated it so it will continue to work when we upgrade the runner OS to macOS 12.
There was a problem hiding this comment.
Leaving this comment unresolved, in case doubts arise on this in the future.
|
Build seems stuck, do will close and reopen the PR as nothing else seem to get |
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
|
Closed in favour of #32 due to the issues with GitHub checks. |
This PR also split workflows in the attempt to decrease the time required to build/release.
Note that the workflow split between
all-libsandlibgit2-onlyis a step stone towards the decommissioning of Managed Transport. Once that takes place we no longer will requireall-libsand the compilation times that comes with it.Relates to fluxcd/source-controller#820 and fluxcd/image-automation-controller#404.