This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Disable libgit2 multi-threading #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Jul 29, 2022
| // of libgit2 without thread support to fix: | ||
| // fluxcd/image-automation-controller/#339. | ||
| // | ||
| // This can be removed once libgit2/git2go#918 is merged. |
There was a problem hiding this comment.
Please link the current PR to the git2go one. We may want to move this fork under fluxcd org if it's not going to be accepted upstream.
added 2 commits
July 31, 2022 11:33
Some users are experiencing segfault issues in Flux controllers which seem to be related to internal git2go state processed within a background thread. Due to the shift into Managed Transport only, the concerns around multi-threading from a libgit2 seem to be less problematic than otherwise, as the management of the transport will be handled by Go. fluxcd/image-automation-controller#339 https://github.com/libgit2/libgit2/blob/main/docs/threading.md Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are experiencing segfault issues in Flux controllers which seem to be related to internal git2go state being processed within a background thread.
Due to the shift into Managed Transport only, the concerns around multi-threading from a libgit2 seem to be less problematic
than otherwise, as the management of the transport will be handled by Go.
We are temporarily running a fork of git2go whilst we wait to see what will happen upstream (libgit2/git2go#918). We also added a check on
make dev-testto ensure the libgit2 version we are consuming was built without thread support.