Add test case for set with boolean value and set-string behavior

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
fluxcd · Jul 23, 2021 · 0ceec2d · 0ceec2d
1 parent c0f72e1
commit 0ceec2d
Showing 1 changed file with 46 additions and 0 deletions.
diff --git a/controllers/helmrelease_controller_test.go b/controllers/helmrelease_controller_test.go
@@ -107,6 +107,52 @@ other: values
 				},
 			},
 		},
+		{
+			name: "target path with boolean value",
+			resources: []runtime.Object{
+				valuesSecret("values", map[string][]byte{"single": []byte("true")}),
+			},
+			references: []v2.ValuesReference{
+				{
+					Kind:       "Secret",
+					Name:       "values",
+					ValuesKey:  "single",
+					TargetPath: "merge.at.specific.path",
+				},
+			},
+			want: chartutil.Values{
+				"merge": map[string]interface{}{
+					"at": map[string]interface{}{
+						"specific": map[string]interface{}{
+							"path": true,
+						},
+					},
+				},
+			},
+		},
+		{
+			name: "target path with set-string behavior",
+			resources: []runtime.Object{
+				valuesSecret("values", map[string][]byte{"single": []byte("\"true\"")}),
+			},
+			references: []v2.ValuesReference{
+				{
+					Kind:       "Secret",
+					Name:       "values",
+					ValuesKey:  "single",
+					TargetPath: "merge.at.specific.path",
+				},
+			},
+			want: chartutil.Values{
+				"merge": map[string]interface{}{
+					"at": map[string]interface{}{
+						"specific": map[string]interface{}{
+							"path": "true",
+						},
+					},
+				},
+			},
+		},
 		{
 			name: "values reference to non existing secret",
 			references: []v2.ValuesReference{