Skip to content

Commit

Permalink
Add tests for Kustomize post renderer
Browse files Browse the repository at this point in the history
Signed-off-by: Hidde Beydals <hello@hidde.co>
  • Loading branch information
hiddeco committed Feb 4, 2021
1 parent c8c8246 commit 456d4c2
Show file tree
Hide file tree
Showing 2 changed files with 224 additions and 82 deletions.
82 changes: 0 additions & 82 deletions controllers/helmrelease_types_test.go

This file was deleted.

224 changes: 224 additions & 0 deletions internal/runner/post_renderer_kustomize_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,224 @@
/*
Copyright 2021 The Flux authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package runner

import (
"bytes"
"encoding/json"
"reflect"
"testing"

v1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
"sigs.k8s.io/yaml"

"github.com/fluxcd/pkg/apis/kustomize"

v2 "github.com/fluxcd/helm-controller/api/v2beta1"
)

const replaceImageMock = `apiVersion: v1
kind: Pod
metadata:
name: image
spec:
containers:
- image: repository/image:tag
`

const json6902Mock = `apiVersion: v1
kind: Pod
metadata:
annotations:
c: foo
name: json6902
`

const strategicMergeMock = `apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
template:
spec:
containers:
- name: nginx
image: nignx:v1.0.0
`

func Test_postRendererKustomize_Run(t *testing.T) {
tests := []struct {
name string
renderedManifests string
patchesStrategicMerge string
patchesJson6902 string
images string
expectManifests string
expectErr bool
}{
{
name: "image tag",
renderedManifests: replaceImageMock,
images: `
- name: repository/image
newTag: 0.1.0
`,
expectManifests: `apiVersion: v1
kind: Pod
metadata:
name: image
spec:
containers:
- image: repository/image:0.1.0
`,
},
{
name: "image name",
renderedManifests: replaceImageMock,
images: `
- name: repository/image
newName: repository/new-image
`,
expectManifests: `apiVersion: v1
kind: Pod
metadata:
name: image
spec:
containers:
- image: repository/new-image:tag
`,
},
{
name: "image digest",
renderedManifests: replaceImageMock,
images: `
- name: repository/image
digest: sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3
`,
expectManifests: `apiVersion: v1
kind: Pod
metadata:
name: image
spec:
containers:
- image: repository/image@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3
`,
},
{
name: "json 6902",
renderedManifests: json6902Mock,
patchesJson6902: `
- target:
version: v1
kind: Pod
name: json6902
patch:
- op: test
path: /metadata/annotations/c
value: foo
- op: remove
path: /metadata/annotations/c
- op: add
path: /metadata/annotations/c
value: [ "foo", "bar" ]
- op: replace
path: /metadata/annotations/c
value: 42
- op: move
from: /metadata/annotations/c
path: /metadata/annotations/d
- op: copy
from: /metadata/annotations/d
path: /metadata/annotations/e
`,
expectManifests: `apiVersion: v1
kind: Pod
metadata:
annotations:
d: 42
e: 42
name: json6902
`,
},
{
name: "strategic merge test",
renderedManifests: strategicMergeMock,
patchesStrategicMerge: `
- apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
template:
spec:
containers:
- name: nginx
image: nignx:latest
`,
expectManifests: `apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
template:
spec:
containers:
- image: nignx:latest
name: nginx
`,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
spec, err := mockKustomize(tt.patchesStrategicMerge, tt.patchesJson6902, tt.images)
k := &postRendererKustomize{
spec: spec,
}
gotModifiedManifests, err := k.Run(bytes.NewBufferString(tt.renderedManifests))
if (err != nil) != tt.expectErr {
t.Errorf("Run() error = %v, expectErr %v", err, tt.expectErr)
return
}
if !reflect.DeepEqual(gotModifiedManifests, bytes.NewBufferString(tt.expectManifests)) {
t.Errorf("Run() gotModifiedManifests = %v, want %v", gotModifiedManifests, tt.expectManifests)
}
})
}
}

func mockKustomize(patchesStrategicMerge, patchesJson6902, images string) (*v2.Kustomize, error) {
b, err := yaml.YAMLToJSON([]byte(patchesStrategicMerge))
if err != nil {
return nil, err
}
var strategicMerge []v1.JSON
if err := json.Unmarshal(b, &strategicMerge); err != nil {
return nil, err
}
var json6902 []kustomize.JSON6902Patch
if err := yaml.Unmarshal([]byte(patchesJson6902), &json6902); err != nil {
return nil, err
}
var imgs []kustomize.Image
if err := yaml.Unmarshal([]byte(images), &imgs); err != nil {
return nil, err
}
return &v2.Kustomize{
PatchesStrategicMerge: strategicMerge,
PatchesJSON6902: json6902,
Images: imgs,
}, nil
}

0 comments on commit 456d4c2

Please sign in to comment.