Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out reconcile logic into separate methods #323

Closed
hiddeco opened this issue Oct 1, 2021 · 0 comments · Fixed by #738
Closed

Split out reconcile logic into separate methods #323

hiddeco opened this issue Oct 1, 2021 · 0 comments · Fixed by #738
Labels
enhancement New feature or request

Comments

@hiddeco
Copy link
Member

hiddeco commented Oct 1, 2021

To facilitate better testing, and an easier to follow reconciliation flow, the current reconcileRelease method should be split out into separate (logical) units that deal with separate stages of the reconciliation process (e.g. installation, testing, remediation, uninstall).

The stages should be self-determining (that being, an inspection of the Helm storage and state), and not rely on any observations of previous state on the HelmRelease itself.

This has been attempted before in #126 and #177, which at the time was more difficult due to the lack of tooling that is going to be introduced with #323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant