api: allow configuration of h unit for timeouts
#549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the other Flux components, there are some scenarios in which a timeout of 1h (or more) is justified to be able to Helm actions which take a long time to finish. To support this, widen the validation added in 54aee36 to allow the configuration of the `h` time unit again. At the cost of theoretically keeping the workers busy for a long duration of time (and thereby not processing other changes), but without causing a full denial of service. Signed-off-by: Hidde Beydals <hello@hidde.co>
|
We need to do the same in KC, the health checks would take as long as the Helm wait. |
stefanprodan
approved these changes
Oct 21, 2022
hiddeco
added a commit
to fluxcd/kustomize-controller
that referenced
this pull request
Oct 21, 2022
To allow waiting for `HelmRelease` resources with an exceptionally high timeout of `1h` or more. Related to: fluxcd/helm-controller#549 Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the other Flux components, there are some scenarios in which a timeout of 1h (or more) is justified to be able to Helm actions which take a long time to finish.
To support this, widen the validation added in
54aee36 to allow the configuration of the
htime unit again. At the cost of theoretically keeping the workers busy for a long duration of time (and thereby not processing other changes), but without causing a full denial of service.Follow up on #533
Fixes #547
Fixes fluxcd/flux2#3227