Allow opt-out of drift correction #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
allow-drift-diff-only
branch
2 times, most recently
from
ebbee2a to
c0361cf
Compare
darkowlzz
approved these changes
Mar 20, 2023
|
@darkowlzz yes, this was still on my list but was nearing my EOD on Friday. |
hiddeco
force-pushed
the
allow-drift-diff-only
branch
3 times, most recently
from
dbb2277 to
75f4fc6
Compare
This enhances the drift detection to allow detection without acting on it by adding a `CorrectDrift` feature gate. When set to `false` (i.e. `--feature-gates=DetectDrift=true,CorrectDrift=false`), the controller will only log the difference it detected without acting on it. This allows for a smoother transition to drift detection, as issues with a number of existing releases can be solved before the feature is enabled in full. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
allow-drift-diff-only
branch
from
75f4fc6 to
46add22
Compare
stefanprodan
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the drift detection to allow detection without acting on it by adding a
CorrectDriftfeature gate. When set tofalse(i.e.--feature-gates=DetectDrift=true,CorrectDrift=false), the controller will only log the difference it detected without acting on it.This allows for a smoother transition to drift detection, as issues with a number of existing releases can be solved before the feature is enabled in full.
Fixes: #645