Add reconciler sharding capability based on label selector #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this enhancement, the controller can be configured with `--watch-label-selector`, after which only objects with this label will be reconciled by the controller. This allows for horizontal scaling of the helm-controller, where each controller can be deployed multiple times with a unique label selector which is used as the sharding key. Note that if you want to ensure a `HelmChart` gets created for a specific source-controller instance, you have to provide the labels for this controller in `.spec.chart.metadata.labels` of the `HelmRelease`. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
watch-label-selector
branch
from
8d8d137
to
08925bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this enhancement, the controller can be configured with
--watch-label-selector, after which only objects with this label will be reconciled by the controller.This allows for horizontal scaling of the helm-controller, where each controller can be deployed multiple times with a unique label selector which is used as the sharding key.
Note that if you want to ensure a
HelmChartgets created for a specific source-controller instance, you have to provide the labels for this controller in.spec.chart.metadata.labelsof theHelmRelease.Part of fluxcd/flux2#3731