This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Update Flux dependency to 1.25.4 #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2022 14:06
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
the CommitsBetween method added a firstParent boolean here, in: fluxcd/flux@42d6f18 fluxcd/flux#2803 If we are calling CommitsBetween here, expecting the old behavior, then it should be set to "false" Signed-off-by: Kingdon Barrett <kingdon@weave.works>
|
This passed the tests, so I'll try it out locally some time this week, and then we can publish a version of Helm Operator with the same stance on default telemetry. 👍 There should be no code changes required to get the new checkpoint code from fluxcd/flux/pkg/checkpoint, just to point at the newer version of Flux as a dependency. I have not tested this at all outside of the CI scaffolding. |
stefanprodan
approved these changes
Aug 31, 2022
|
@kingdonb we need a replace to update |
added 2 commits
August 31, 2022 13:13
#661 (comment) Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to see if we can easily land this update here:
(Let's run the CI and see how this change goes, something tells me there's a reason that Flux here is still pinned to 1.18...)