Merge pull request #287 from fluxcd/log-when-rmall

Log the error when removing the working dir fails
fluxcd · Jan 6, 2022 · 90dcdfd · 90dcdfd
2 parents f82654d + 8e1f31f
commit 90dcdfd
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/controllers/imageupdateautomation_controller.go b/controllers/imageupdateautomation_controller.go
@@ -215,7 +215,11 @@ func (r *ImageUpdateAutomationReconciler) Reconcile(ctx context.Context, req ctr
  if err != nil {
  return failWithError(err)
  }
- defer os.RemoveAll(tmp)
+ defer func() {
+ if err := os.RemoveAll(tmp); err != nil {
+ log.Error(err, "failed to remove working directory", "path", tmp)
+ }
+ }()
 
  // FIXME use context with deadline for at least the following ops