Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Managed Transport #370

Closed
pjbgf opened this issue May 27, 2022 · 1 comment
Closed

Test Managed Transport #370

pjbgf opened this issue May 27, 2022 · 1 comment
Milestone

Comments

@pjbgf
Copy link
Member

pjbgf commented May 27, 2022

The Git related tests must be refactored to ensure the Managed Transport is being used.
Given that a lot of the testing logic is based on git2go, by enabling the Manage Transport of the controller we are also changing the behaviour of the tests themselves.

Extra points to consider:

  • libgit2 checkout func now have the side effect of removing the Transport Options even if they were added by the caller. We probably want to change this.
  • Run both managed and unmanaged tests whilst we support the latter.
@pjbgf
Copy link
Member Author

pjbgf commented Aug 25, 2022

Managed transport has been deprecated since v0.24.0 and therefore this is no longer required.

@pjbgf pjbgf closed this as completed Aug 25, 2022
Repository owner moved this from Up-Next to Since Last Dev Meeting in Maintainers' Focus Aug 25, 2022
@pjbgf pjbgf moved this from Since Last Dev Meeting to Done in Maintainers' Focus Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant