Enable Managed Transport by default #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
force-pushed
the
libgit2-cacheless-conns
branch
from
7b32358
to
bef2616
Compare
pjbgf
force-pushed
the
libgit2-cacheless-conns
branch
3 times, most recently
from
e6fe7c0
to
7444a05
Compare
pjbgf
force-pushed
the
libgit2-cacheless-conns
branch
2 times, most recently
from
2afe95d
to
48bcca5
Compare
|
Encountered a few issues whilst updating source-controller which resulted in fixing a regression and creating a new issue for the follow-up task of enabling the tests to run against the Managed Transport version of the controller. |
|
Manually tested on both GitHub and DevOps.
|
This was referenced May 27, 2022
Merged
aryan9600
reviewed
May 28, 2022
hiddeco
approved these changes
Jun 1, 2022
added 2 commits
June 1, 2022 21:03
GitManagedTransport enables the use of Managed Transport. This replaces the previous 'EXPERIMENTAL_GIT_TRANSPORT' environment variable that was used for the same result. This commit also enables it by default. This is an opt-out feature, which can be disabled by starting the controller with the argument '--feature-gates=GitManagedTransport=false'. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
- Panic recovery for Git operations. - Improved SSH connection management without use of caching. - Enforce context timeout for managed SSH. - Remove dependency to callback functions. - Add support for hashed known_hosts. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
stefanprodan
force-pushed
the
libgit2-cacheless-conns
branch
2 times, most recently
from
1a129d4
to
e07a9ec
Compare
Fixes regression in which IAC will fail to update push branch when the push branch already exists and checkout branch is ahead. The reconciliation errors with: 'cannot push because a reference that you are trying to update on the remote contains commits that are not present locally.' Regression introduced on fluxcd#330. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
stefanprodan
force-pushed
the
libgit2-cacheless-conns
branch
from
e07a9ec
to
ebc40b2
Compare
aryan9600
pushed a commit
to aryan9600/image-automation-controller
that referenced
this pull request
Jun 2, 2022
Fixes regression in which we fail to push to a branch after switching to a branch, if origin is ahead of local. Fixed by setting the upstream commit as the local branch target. Regression introduced in fluxcd#330, and partially addressed in fluxcd#369. Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
aryan9600
pushed a commit
to aryan9600/image-automation-controller
that referenced
this pull request
Jun 2, 2022
Fixes regression in which we fail to push to a branch after switching to a branch, if origin is ahead of local. Fixed by setting the upstream commit as the local branch target. Regression introduced in fluxcd#330, and partially addressed in fluxcd#369. Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
aryan9600
pushed a commit
to aryan9600/image-automation-controller
that referenced
this pull request
Jun 2, 2022
Fixes regression in which we fail to push to a branch after switching to a branch, if origin is ahead of local. Fixed by setting the upstream commit as the local branch target. Regression introduced in fluxcd#330, and partially addressed in fluxcd#369. Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
aryan9600
pushed a commit
to aryan9600/image-automation-controller
that referenced
this pull request
Jun 2, 2022
Fixes regression in which we fail to push to a branch after switching to a branch, if origin is ahead of local. Fixed by setting the upstream commit as the local branch target. Regression introduced in fluxcd#330, and partially addressed in fluxcd#369. Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
aryan9600
pushed a commit
to aryan9600/image-automation-controller
that referenced
this pull request
Jun 2, 2022
Fixes regression in which we fail to push to a branch after switching to a branch, if origin is ahead of local. Fixed by setting the upstream commit as the local branch target. Regression introduced in fluxcd#330, and partially addressed in fluxcd#369. Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
souleb
pushed a commit
to souleb/image-automation-controller
that referenced
this pull request
Mar 12, 2024
Fixes regression in which we fail to push to a branch after switching to a branch, if origin is ahead of local. Fixed by setting the upstream commit as the local branch target. Regression introduced in fluxcd#330, and partially addressed in fluxcd#369. Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test image:
ghcr.io/fluxcd/image-automation-controller:rc-48bcca59