git: Enable managed transport by default #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitManagedTransport enables the use of Managed Transport. This replaces the previous 'EXPERIMENTAL_GIT_TRANSPORT' environment variable that was used for the same result. This commit also enables it by default. This is an opt-out feature, which can be disabled by starting the controller with the argument '--feature-gates=GitManagedTransport=false'. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
changed the title
@stefanprodan With the new way of initialising this would be enough, however, the version of SC this uses still lingers on that environment variable to check the Managed Transport status. We will need to first get it merged and released on SC before we can do the same here. I created the PR for SC and will keep this as draft until we are ready to update/merged it. |
|
superseded by #369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitManagedTransportis a new feature gate that enables the use of Managed Transport.This replaces the previous
EXPERIMENTAL_GIT_TRANSPORTenvironment variable that wasused for the same result.
This is now an
opt-outfeature, which can be disabled by starting thecontroller with the argument '--feature-gates=GitManagedTransport=false'.
This is part of a series of changes that happened on source-controller that needs to be synced with IAC.