Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add controller concurrency #192

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

makkes
Copy link
Member

@makkes makkes commented Jun 24, 2021

The controller is now working with 4 concurrent workers by default.
This value is configurable through the --concurrent flag.

Signed-off-by: Max Jonas Werner mail@makk.es

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have recorded a nitpick; modulo that, this is good to go, thank you @makkes

controllers/imageupdateautomation_controller.go Outdated Show resolved Hide resolved
The controller is now working with 4 concurrent workers by default.
This value is configurable through the `--concurrent` flag.

Signed-off-by: Max Jonas Werner <mail@makk.es>
@makkes makkes force-pushed the makkes/concurrent-reconciles branch from 283a3d9 to 9378275 Compare June 24, 2021 18:15
@makkes makkes requested a review from squaremo June 25, 2021 06:03
@makkes
Copy link
Member Author

makkes commented Jun 25, 2021

@squaremo Thanks for the review! I addressed your comment.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @makkes

@stefanprodan stefanprodan merged commit c1533ea into fluxcd:main Jun 25, 2021
@makkes makkes deleted the makkes/concurrent-reconciles branch June 25, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants