Use strings.TrimRight to determine image name #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu
force-pushed
the
slice-bounds-range-image-name
branch
from
cac285c to
e85d5e6
Compare
stefanprodan
approved these changes
Nov 5, 2021
This is to prevent a slice bounds out of range error. Fixes #243 Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu
force-pushed
the
slice-bounds-range-image-name
branch
from
e85d5e6 to
bdf73cb
Compare
hiddeco
reviewed
Nov 8, 2021
There was a problem hiding this comment.
This does not seem to do exactly the same as the previous logic: https://play.golang.org/p/nFtkz2oNQPl
|
@hiddeco image := policy.Status.LatestImage |
hiddeco
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent a slice bounds out of range error.
Fixes #243