Add experimental managed transport for libgit2 operations #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
hiddeco
reviewed
Mar 21, 2022
libgit2 network operations are blocking and do not provide timeout nor context capabilities, leading to several reports of the controllers hanging indefinitely. By using managed transport, golang primitives such as http.Transport and net.Dial can be used to ensure timeouts are enforced. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2network operations are blocking and do not provide timeout nor context capabilities, leading to users reporting that image-automation-controller hanging indefinitely.By using managed transport, golang primitives such as http.Transport and net.Dial can be used to ensure timeouts are enforced.
This will initially be guarded behind a feature switch via environment variable
EXPERIMENTAL_GIT_TRANSPORT.Extends from fluxcd/source-controller#606
Affected issues: #209 #286 #282