Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/fluxcd/source-controller v0.25.5 #384

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Jun 8, 2022

This version of source-controller fixes an issue when checking known_hosts by which previous attempted hashes would overflow into the subsequent hash input, rendering the results invalid. This would only impact cases in which multiple hashes were provided for a single target host.

Fixes #378.

Unverified

No user is associated with the committer email.
- github.com/fluxcd/source-controller to version 0.25.5.
- github.com/fluxcd/source-controller/api to version 0.25.5.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf added the area/ci CI related issues and pull requests label Jun 8, 2022
@pjbgf pjbgf requested a review from stefanprodan June 8, 2022 10:50
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to #378 and explain in the description how this fixed a regression bug.

@pjbgf pjbgf requested a review from stefanprodan June 8, 2022 11:01
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@pjbgf pjbgf merged commit 8d5ae79 into fluxcd:main Jun 8, 2022
@pjbgf pjbgf deleted the update-deps branch June 8, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH host key errors with v0.23.0
2 participants