-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decommission libgit2 Unmanaged Transport #412
Conversation
- k8s.io/api to version 0.24.3. - k8s.io/apimachinery to version 0.24.3. - k8s.io/client-go to version 0.24.3. - github.com/fluxcd/image-reflector-controller/api to version 0.20.0. - github.com/fluxcd/source-controller to version 0.26.0. - k8s.io/* to version v0.24.3. - k8s.io/kube-openapi to version v0.0.0-20220803164354-a70c9af30aea. - github.com/ProtonMail/go-crypto to version v0.0.0-20220730123233-d6ffb7692adf. - sigs.k8s.io/kustomize/kyaml to version v0.13.9. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @pjbgf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ImageUpdateAutomationReconciler
needs to be updated to have Libgit2TransportInitialized
as a field (ref: https://github.com/fluxcd/source-controller/blob/v0.26.0/controllers/gitrepository_controller.go#L120) and the reconcile logic needs to verify whether libgit2 transports have been initialized before performing any git operations.
The GitManagedTransport
feature needs to be removed from internal/features/features.go
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@aryan9600 just removed For |
This has been tested against GitHub, GitLab and BitBucket. All worked as expected. |
Decomissions libgit2 Unmanaged Transport and updates the dependencies below: