gogit: Add new ForceGoGitImplementation FeatureGate #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
1f94e96
to
4f99ec5
Compare
aryan9600
requested changes
Nov 4, 2022
internal/features/features.go
Outdated
Comment on lines
25
to
26
| // ForceGoGitImplementation ignores the value set for gitImplementation | ||
| // and ensures that go-git is used for all GitRepository objects. |
There was a problem hiding this comment.
Suggested change
| // ForceGoGitImplementation ignores the value set for gitImplementation | |
| // and ensures that go-git is used for all GitRepository objects. | |
| // ForceGoGitImplementation ignores the value set for gitImplementation | |
| // of a GitRepository object and ensures that go-git is used for all git operations. |
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
4f99ec5
to
823147a
Compare
ForceGoGitImplementation ignores the value set for gitImplementation and ensures that go-git is used for all GitRepository objects. This can be used to confirm that Flux instances won't break if/when the libgit2 implementation was to be deprecated. When enabled, libgit2 won't be initialized, nor will any git2go cgo code be called. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
feature-nolibgit2
branch
from
823147a
to
0191d6b
Compare
22 tasks
stefanprodan
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForceGoGitImplementation ignores the value set for gitImplementation and ensures that go-git is used for all GitRepository objects. This can be used to confirm that Flux instances won't break if/when the libgit2 implementation was to be deprecated.
When enabled, libgit2 won't be initialized, nor will any git2go cgo code be called.