Update controller-runtime, Kubernetes and kyaml dependencies #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- github.com/fluxcd/pkg/apis/meta to version 1.1.0 - github.com/fluxcd/source-controller/api to version 1.0.0-rc.3 - k8s.io/apimachinery to version 0.27.2 - sigs.k8s.io/controller-runtime to version 0.15.0 Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
update-ctrl-runtime
branch
8 times, most recently
from
19bcbf1
to
4d9d5e6
Compare
|
Can you please mention kyaml as this is the major update, controller-runtime has no affect on end-users. |
hiddeco
force-pushed
the
update-ctrl-runtime
branch
2 times, most recently
from
9720e24
to
c498a58
Compare
hiddeco
changed the title
This deals with various breaking changes in controller-runtime, as documented in the release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 In short: - `Watches` now use a `client.Object` instead of a `source.Kind`. - `handler.MapFunc` signature accepts a Go context, which is used to log any errors, instead of silently ignoring them and/or panicking. - Fake clients used in tests are now configured using `WithStatusSubresource` to enable the correct behavior for status updates and patches. - Max concurrent reconciles and panic recovery is configured on the manager, instead of configuring them per reconciler instance. - Various manager configuration options have been moved to new structures and/or fields. In addition to this, all other dependencies which had updates are updated to their latest (compatible) versions as well. Including an update of kyaml to match Kustomize v5. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
update-ctrl-runtime
branch
from
c8dc943
to
7cc9c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with various breaking changes in controller-runtime, as
documented in the release notes:
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0
In short:
Watchesnow use aclient.Objectinstead of asource.Kind.handler.MapFuncsignature accepts a Go context, which is used tolog any errors, instead of silently ignoring them and/or panicking.
WithStatusSubresourceto enable the correct behavior for statusupdates and patches.
manager, instead of configuring them per reconciler instance.
structures and/or fields.
In addition to this, all other dependencies which had updates are
updated to their latest (compatible) versions as well. Including an
update of kyaml to match Kustomize v5.
Part of: fluxcd/flux2#3907 and fluxcd/flux2#3564