Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push branch reporting when is equal to checkout branch #581

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

aryan9600
Copy link
Member

Fix the push branch reported in the logs and status if .spec.git.push.branch==.spec.git.checkout.branch.

Fixes #580

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a tests for the status message to verify that it contains the new branch name and/or refspec.

@stefanprodan stefanprodan added the area/git Git related issues and pull requests label Sep 4, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🏅

Fix the push branch reported in the logs and status if
`.spec.git.push.branch==.spec.git.checkout.branch`.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@stefanprodan stefanprodan changed the title fix push branch reporting if its equal to checkout branch Fix push branch reporting when is equal to checkout branch Sep 18, 2023
@stefanprodan stefanprodan merged commit 02dadfd into main Sep 18, 2023
7 checks passed
@stefanprodan stefanprodan deleted the fix-status branch September 18, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch name missing from commit event
2 participants