Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageRepository not populating Last Scan in additionalPrinterColumns #118

Closed
nomeelnoj opened this issue Mar 12, 2021 · 1 comment · Fixed by #119
Closed

ImageRepository not populating Last Scan in additionalPrinterColumns #118

nomeelnoj opened this issue Mar 12, 2021 · 1 comment · Fixed by #119
Assignees
@relu
Labels
bug Something isn't working

Comments

@nomeelnoj
Copy link

nomeelnoj commented Mar 12, 2021 •
edited
Loading

The additionalPrinterColumn for LAST SCAN is not populating. I believe it was #56 that introduced this. I have confirmed that updating the CRD as follows populates the field:

https://github.com/fluxcd/image-reflector-controller/blob/main/config/crd/bases/image.toolkit.fluxcd.io_imagerepositories.yaml#L20

should instead read

.status.lastScanResult.scanTime
@relu relu self-assigned this Mar 12, 2021
@relu relu added the bug Something isn't working label Mar 12, 2021
relu added a commit that referenced this issue Mar 12, 2021
@relu
Fix "last scan" print column for ImageRepository
428594f 
Fixes #118

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu mentioned this issue Mar 12, 2021
Merged
@relu
Copy link
Member

relu commented Mar 12, 2021

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@relu relu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "last scan" print column for ImageRepository fluxcd/image-reflector-controller
2 participants
@relu @nomeelnoj