Better error reporting for image policy evaluation #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more verbose message associated with the error should give the user better understanding of the cause and the nature of the failure. Fixes #143 Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
relu
force-pushed
the
error-reporting-image-policy
branch
2 times, most recently
from
dd743fb to
746f61e
Compare
squaremo
approved these changes
May 25, 2021
| @@ -66,7 +66,7 @@ func (p *Numerical) Latest(versions []string) (string, error) { | |||
|
|
|||
| switch { | |||
| case i == 0: | |||
| break // First iteration, nothing to compare | |||
| // First iteration, nothing to compare | |||
There was a problem hiding this comment.
I like the explicit break, since it disambiguates for people who have trouble remembering whether Go's case has fall-through or not (like me).
There was a problem hiding this comment.
I just went with the linter recommendation. I can definitely revert back to using break if you think it's worth it, no problem.
There was a problem hiding this comment.
I often find myself disagreeing with linters. Maybe I should consider .... rewriting all the linters ...
There was a problem hiding this comment.
Not a blocker, I leave it to your judgement @relu :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more verbose message associated with the error should give the user
better understanding of the cause and the nature of the failure.