Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to autologin flags if no provider is specified #353

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fallback to autologin flags if no provider is specified #353

merged 1 commit into from
Mar 8, 2023

Conversation

aryan9600
Copy link
Member

Use the value of autologin flags if spec.provider is not set or set to generic.

Fixes #352

@hiddeco hiddeco changed the title fallback to autlogin flags if no provider is specified Fallback to autlogin flags if no provider is specified Mar 8, 2023
hiddeco
hiddeco approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With impact full changes like this (or reverts because we did something wrong). It's often good to include reasoning with your commit to make your case, and helps when we later look at things (to see if we can now remove them) using e.g. git blame.

@aryan9600
fallback to autlogin flags if no provider is specified
67eaa5a 
Use the value of autologin flags if `spec.provider` is not set or set to
`generic`.
Addresses a breaking change made in 685f7be which ignored the flags in
favor of `.spec.provider` forcing users to modify all their
`ImageRepository` objects to specify the required provider.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@hiddeco hiddeco merged commit b945569 into fluxcd:main Mar 8, 2023
@hiddeco hiddeco changed the title Fallback to autlogin flags if no provider is specified Fallback to autologin flags if no provider is specified Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

image-reflector-controller 0.40.0 breaking change gives no room for upgrading transparently
2 participants
@aryan9600 @hiddeco