Fix status reporting when the source is not found #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
area/kustomize
hiddeco
reviewed
Oct 14, 2020
|
|
||
| // check source readiness | ||
| if source.GetArtifact() == nil { | ||
| if err != nil || source.GetArtifact() == nil { |
There was a problem hiding this comment.
Looking at the logic of getSource, the result of this is that a "not found" or transient error (they are both the same there, instead of relying on apierrors.IsNotFound()) is equal to the source not being ready (in messaging). I am not sure if this is what you are after.
There was a problem hiding this comment.
Good point 👍 Please check the latest push.
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
fix-source-404
branch
from
9af0de6
to
4fc1466
Compare
hiddeco
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the source is not found the status wasn't updated accordingly.