Implement container image setters #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somtochiama
force-pushed
the
override-image
branch
2 times, most recently
from
38ca719
to
cf8bf1f
Compare
stefanprodan
added
area/kustomize
somtochiama
force-pushed
the
override-image
branch
from
282ac16
to
d0b87cc
Compare
somtochiama
changed the title
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
override-image
branch
from
4baac87
to
bca3a40
Compare
| run: | | ||
| kubectl create ns override-test | ||
| kubectl -n override-test apply -f ./config/testdata/overrides | ||
| ACTUAL_TAG=$(kubectl -n override-test get deployments podinfo -o jsonpath='{.spec.template.spec.containers[0].image}' | cut -f2 -d ":") |
There was a problem hiding this comment.
Before this check, we need to wait for the kustomization to reconcile first with:
kubectl -n override-test wait kustomizations/podinfo --for=condition=ready --timeout=1m
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
override-image
branch
from
03f5c33
to
ddc4eb6
Compare
stefanprodan
changed the title
stefanprodan
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #193
Supersede: #149.