impersonation: Clear config.BearerTokenFile when setting BearerToken. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running in a cluster, the BearerTokenFile is set to point to `/var/run/secrets/kubernetes.io/serviceaccount/token` where the service account's token is auto-mounted. If this value is not cleared, the setting of the BearerToken field will have no effect. Relevant documentation: https://pkg.go.dev/k8s.io/client-go@v0.20.2/rest#Config.BearerTokenFile Signed-off-by: Brian Atkinson <brian@atkinson.mn>
nairb774
force-pushed
the
priceless_meitner
branch
from
6b215a1
to
2ca0edc
Compare
stefanprodan
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a cluster, the BearerTokenFile is set to point to
/var/run/secrets/kubernetes.io/serviceaccount/tokenwhere the serviceaccount's token is auto-mounted. If this value is not cleared, the
setting of the BearerToken field will have no effect. Relevant
documentation:
https://pkg.go.dev/k8s.io/client-go@v0.20.2/rest#Config.BearerTokenFile