Retry with exponential backoff when fetching artifacts #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
approved these changes
Feb 26, 2021
hiddeco
added a commit
to fluxcd/flux2
that referenced
this pull request
Mar 3, 2021
This check becomes obsolete as soon as fluxcd/kustomize-controller#289 has been released, but prevents the bootstrap process from erroring on `failed to download artifact from [..] connect: connection refused` errors when the source-controller is taking a longer time to boot. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
added a commit
to fluxcd/flux2
that referenced
this pull request
Mar 3, 2021
This check becomes obsolete as soon as fluxcd/kustomize-controller#289 has been released, but prevents the bootstrap process from erroring on `failed to download artifact from [..] connect: connection refused` errors when the source-controller is taking a longer time to boot. Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements retries with exponential backoff when fetching artifacts from source-controller. By default, the controller does 10 attempts within a 3.5 minutes window, the number of max retries can be configure using the
--http-retrycmd arg.This mitigates the alert spam (
i/o timeout err) when source-controller becomes unavailable for a short period of time e.g. after an upgrade.Example error log:
{"level":"error","ts":"2021-02-26T12:03:19.710+0200","logger":"controller.kustomization","msg":"Reconciliation failed after 3m35.317406763s, next try in 5m0s","reconciler group":"kustomize.toolkit.fluxcd.io","reconciler kind":"Kustomization","name":"podinfo","namespace":"flux-system","revision":"master/e43ebfa5bf4b87c46f2e1db495eb571cd398e2f7","error":"failed to download artifact, error: GET http://localhost:8080/gitrepository/flux-system/podinfo/e43ebfa5bf4b87c46f2e1db495eb571cd398e2f7.tar.gz giving up after 10 attempt(s): Get \"http://localhost:8080/gitrepository/flux-system/podinfo/e43ebfa5bf4b87c46f2e1db495eb571cd398e2f7.tar.gz\": dial tcp [::1]:8080: connect: connection refused"}Ref: fluxcd/flux2#661 fluxcd/notification-controller#76