Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log level info for 'Dependencies do not meet ready condition' #317

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

allenporter
Copy link
Contributor

Reduce the log level from error to info to match the level of the event. The kustomize-controller pod's log has error message like:

{"level":"error","ts":"2021-03-26T02:39:43.980Z","logger":"controller.kustomization","msg":"Dependencies do not meet ready condition, retrying in 30s","reconciler group":"kustomize.toolkit.fluxcd.io","reconciler kind":"Kustomization","name":"apps","namespace":"flux-system","error":"dependency 'flux-system/infrastructure' is not ready"}

though the events / notifications written are at level info.

Context is discussion at fluxcd/flux2#1160 (reply in thread)

Reduce the log level from error to info to match the level of the event.

Signed-off-by: Allen Porter <allen.porter@gmail.com>
Signed-off-by: Allen Porter <allen@thebends.org>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @allenporter

@stefanprodan stefanprodan merged commit 23f08ba into fluxcd:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants