Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort dependencies with Tarjan's SCCS algorithm #32

Merged
merged 1 commit into from
May 8, 2020
Merged

Sort dependencies with Tarjan's SCCS algorithm #32

merged 1 commit into from
May 8, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented May 8, 2020 •
edited
Loading

  • Tarjan SCCS algorithm implementation
  • tests

@hiddeco hiddeco force-pushed the dep-sort branch 6 times, most recently from f19023b to 0b0dcae Compare May 8, 2020 12:23
@hiddeco hiddeco changed the title Sort dependencies based on Tarjan's SCCS algorithm Sort dependencies with Tarjan's SCCS algorithm May 8, 2020
@hiddeco hiddeco marked this pull request as ready for review May 8, 2020 12:48
@hiddeco hiddeco requested a review from stefanprodan May 8, 2020 12:48
stefanprodan
stefanprodan approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🥇

@stefanprodan stefanprodan merged commit 6cfe2ff into master May 8, 2020
@stefanprodan stefanprodan deleted the dep-sort branch May 8, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddeco @stefanprodan