Add Checksum Annotation as Transformer to Kustomization #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
jonathan-innis
force-pushed
the
add-checksum-annotation
branch
from
9890d66 to
9178ea1
Compare
|
@stealthybox This addresses the checksum issue |
|
Can you add a little information about the issue that is being addressed? As I can see what this does, but can not directly see why we want to do this. |
|
Sure, addresses #305. @stealthybox and I have had some discussion around tracking stale resources regardless of whether the Kustomization has GC enabled. The proposed solution was that we duplicate the data into annotations and don't break current users by adding it always to labels. This solves an issue that has been blocking the Azure Arc team trying to track which resources were recently deployed and which ones are stale. |
|
Closing this because it will not be taken in its current state 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid always adding this to labels (and to not break current users), the proposed solution is to add an AnnotationTransformer to add the checksum as an annotation to track stale resources deployed by Kustomization