Make the kubeconfig secrets compatible with SOPS #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `values.yaml` to the supported kubeconfig secret key names in order for SOPS to correctly detect the storage format based on the file extension. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
enhancement
hiddeco
reviewed
Aug 4, 2021
| if !ok { | ||
| var kubeConfig []byte | ||
| for k, _ := range secret.Data { | ||
| if k == "value" || k == "value.yaml" { |
There was a problem hiding this comment.
Given these are parts of a contract (they are defined explicitly in the spec), I would make them more "official" part of the programmatic API by e.g. making them constants.
There was a problem hiding this comment.
This must move to fluxcd/pkg/runtime/client so I would leave it here as it is since this function will no longer be in each controller.
hiddeco
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
values.yamlto the supported kubeconfig secret key names in order for SOPS to correctly detect the storage format based on the file extension.Fix: #399
TODO: This must be ported to helm-controller before the next flux release.