Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move controllers into internal package #499

Closed
Tracked by #436
makkes opened this issue Mar 23, 2023 · 0 comments · Fixed by #500
Closed
Tracked by #436

Move controllers into internal package #499

makkes opened this issue Mar 23, 2023 · 0 comments · Fixed by #500
Assignees
@makkes
Milestone
Bootstrap GA

Comments

@makkes
Copy link
Member

makkes commented Mar 23, 2023

Given controllers aren't deemed public packages and we want to publish v1 of n-c soon we agreed to move all controllers into the internal package to clarify these don't expose any public interfaces (and actually preventing them to be imported going forward).
@makkes makkes mentioned this issue Mar 23, 2023
Closed
20 tasks
@makkes makkes self-assigned this Mar 23, 2023
@makkes makkes added this to the Bootstrap GA milestone Mar 23, 2023
makkes pushed a commit that referenced this issue Mar 23, 2023
move all controllers to internal package
61a4351 
closes #499

Signed-off-by: Max Jonas Werner <mail@makk.es>
@makkes makkes mentioned this issue Mar 23, 2023
Merged
makkes pushed a commit that referenced this issue Mar 24, 2023
move all controllers to internal package
328ad7b 
closes #499

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue Mar 27, 2023
move all controllers to internal package
fc3ee10 
closes #499

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue Mar 30, 2023
move all controllers to internal package
5c86b2b 
closes #499

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue Mar 30, 2023
move all controllers to internal package
0c0109a 
closes #499

Signed-off-by: Max Jonas Werner <mail@makk.es>
alekspog pushed a commit to alekspog/notification-controller that referenced this issue Mar 30, 2023
@alekspog
move all controllers to internal package
60ef10d 
closes fluxcd#499

Signed-off-by: Max Jonas Werner <mail@makk.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makkes makkes

Labels
None yet
Projects
None yet
Milestone
Bootstrap GA
Development

Successfully merging a pull request may close this issue.

move all controllers to internal package fluxcd/notification-controller
1 participant
@makkes