Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Operations Test Server #335

Open
7 of 16 tasks
Tracked by #3039
pjbgf opened this issue Apr 5, 2022 · 2 comments
Open
7 of 16 tasks
Tracked by #3039

Git Operations Test Server #335

pjbgf opened this issue Apr 5, 2022 · 2 comments
Labels
area/git Git and SSH related issues and pull requests

Comments

@pjbgf
Copy link
Member

pjbgf commented Apr 5, 2022

The test coverage around git operations heavily relies on gitkit for self-contained tests. For E2E tests we also rely on directly accessing SaaS providers (e.g. GitHub) to ensure that our git implementation is consistently working across all out supported platforms.

Unfortunately, different SaaS providers support a different range of crypto algorithms, Git protocol versions, etc. Our upstream dependencies may introduce changes that may break specific features with said SaaS providers.

Instead of creating E2E tests for every single major SaaS provider, we could instead create or improving the existing git server to enable us to test features we want to support, and therefore quickly understand regression before releasing changes.

Below is a brain dump of specific features that are based on different issues that users have reported, and ideally a git test server would support:

These items should enable the test coverage to extend to support each one of the points above.

@pjbgf pjbgf added the area/git Git and SSH related issues and pull requests label Apr 5, 2022
@pjbgf pjbgf added this to the GA milestone Apr 5, 2022
@pjbgf
Copy link
Member Author

pjbgf commented Apr 25, 2022

The Git Test Server should also ignore the value of GIT_CONFIG_GLOBAL. xref fluxcd/source-controller#686

@pjbgf pjbgf added this to the GA milestone Aug 25, 2022
@pjbgf pjbgf transferred this issue from fluxcd/source-controller Aug 25, 2022
@pjbgf pjbgf removed this from the GA milestone Aug 25, 2022
@pjbgf
Copy link
Member Author

pjbgf commented Dec 6, 2022

Now are are in course to be mono git implementation, a lot of this could actually be implemented and upstreamed. The E2E use cases would be enough to detect changes problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git and SSH related issues and pull requests
Projects
Status: Blocked
Development

No branches or pull requests

1 participant