Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ssh server to have artificial latency #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aryan9600
Copy link
Member

Introduces an option in the SSH server to simulate latency.

Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600 aryan9600 requested a review from pjbgf May 6, 2022 09:38
@pjbgf
Copy link
Member

pjbgf commented May 6, 2022

Really good start! I am just not quite sure whether we need the latency on a single place, or several.
Places that comes to mind:

  • Handshake/Establishing connection.
  • Before command execution.
  • After command execution.

But what are your thoughts on potentially making this a two settings feature: Enabled/Disabled and Maximum Latency.
Then when enabled, just randomly pick a latency within the range and inject at the different points.

Ultimately, we want to ensure that the client will be able to deal with the latency gracefully, hopefully fulfil the operation, but certainly won't freeze nor panic.

@pjbgf pjbgf changed the title Modify ssh server to have artifical latency Modify ssh server to have artificial latency May 6, 2022
@pjbgf pjbgf mentioned this pull request Aug 25, 2022
16 tasks
@pjbgf pjbgf added the enhancement New feature or request label May 11, 2022
@pjbgf pjbgf added this to the GA milestone May 11, 2022
@pjbgf pjbgf removed this from the GA milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants