-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: Requirements to move back to go-git/go-git
#397
Labels
area/git
Git and SSH related issues and pull requests
Comments
codablock
added a commit
to kluctl/kluctl
that referenced
this issue
Dec 13, 2022
See fluxcd/pkg#397, especially in regard to skeema/knownhosts breaking compatibility
5 tasks
Runnign the tests using upstream
The former is fixed by go-git/go-git#655. The latter will require the upstreaming of fluxcd/go-git#9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
go-git/go-git
dependency has recently been replaced with fluxcd/go-git`. In order to be able to move back to the upstream project, we need:Upstream performance improvements
Upstream behaviour changes
go-git/go-git
: Surface a way for users to change unsupported capabilities.multi_ack
capability go-git/go-git#613skeema/knownhosts
and/orgo-git/go-git
: Add support for auto-populate HostKeyAlgorithms for non file-based knownhosts.fluxcd/go-git
reverts some of its changes so that the latest versions ofgo-git/go-git
continue to work with Flux.HostKeyAlgorithms
is a great feature to have and will decrease the likelihood of issues such as:The text was updated successfully, but these errors were encountered: