actions/envtest: Update to docker container action #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
envtest-docker-action
branch
6 times, most recently
from
5f230c2
to
d7be130
Compare
hiddeco
reviewed
Aug 1, 2021
actions/envtest/action.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: Setup envtest | |||
| description: A GitHub Action for setting up controller-runtime envtest | |||
| author: Stefan Prodan | |||
| author: Flux authors | |||
There was a problem hiding this comment.
Suggested change
| author: Flux authors | |
| author: Flux project |
maybe? Not sure what the best option is.
There was a problem hiding this comment.
project sounds good.
Updated.
Update action/envtest to be a docker container action. This helps install envtest binaries without Go installed on the host. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
envtest-docker-action
branch
from
d7be130
to
26a3f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update action/envtest to be a docker container action. This helps
install envtest binaries without Go installed on the host.
Refer: fluxcd/source-controller#404