Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helmtestserver to optionally sign packaged charts #248

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

aryan9600
Copy link
Member

Adds a new method PackageSignedChartWithVersion which generates a PGP keypair and uses it to sign the packaged chart, along with a minor refactor. Adds tests for helmtestserver.

@aryan9600 aryan9600 force-pushed the helm-sign branch 2 times, most recently from 1f82ae4 to ff1ef66 Compare March 3, 2022 19:23
helmtestserver/server_test.go Outdated Show resolved Hide resolved
helmtestserver/server_test.go Outdated Show resolved Hide resolved
helmtestserver/server_test.go Outdated Show resolved Hide resolved
helmtestserver/server.go Outdated Show resolved Hide resolved
helmtestserver/server.go Outdated Show resolved Hide resolved
helmtestserver/server.go Outdated Show resolved Hide resolved
helmtestserver/server.go Outdated Show resolved Hide resolved
@aryan9600 aryan9600 requested a review from darkowlzz March 4, 2022 12:25
@hiddeco hiddeco added area/testserver Test server related issues and pull requests enhancement New feature or request labels Mar 4, 2022
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please update the year in the license header and rebase.

Add functionality to sign packaged charts using an openpgp keyring. Add
tests related to helmtestserver. This helps test consumers to in chart
verification using a provenance file.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testserver Test server related issues and pull requests enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants