ssh: Update PreferredKexAlgos based on golang.org/x/crypto/ssh #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2022 10:30
The previous implementation did not include these algorithms as part of the preferred. Given that recommendations is for both items not to be used due to security concerns, they may as well be removed from here. xref: https://tools.ietf.org/id/draft-ietf-curdle-ssh-kex-sha2-09.html Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Aligns preferred algorithms with upstream golang.org/x/crypto/ssh, resulting in adding support to two new kex algorithms on PreferredKexAlgos: - curve25519-sha256 - diffie-hellman-group14-sha256 Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
|
@somtochiama are you aware of any place where this code is being used? |
- golang.org/x/crypto to v0.0.0-20220427172511-eb4f295cb31f Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
2 tasks
hiddeco
approved these changes
May 6, 2022
|
@pjbgf I remember using for this pull request |
|
@somtochiama thank you for the confirmation. It seems like this is not being used within the fluxcd org. I will merge this PR, as if this is being used, the changes will be beneficial. However, we probably should start looking into decommissioning this code in the future if we don't find whether it is needed/used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns preferred algorithms with upstream golang.org/x/crypto/ssh, resulting in adding support to two new kex algorithms on PreferredKexAlgos:
Removes references to unused algorithms that are no longer recommended for use:
This code does not seem to be called anywhere. An alternative change may be to simply removing it from the module so we don't need to update it going forwards.