runtime: Use server-side throttling when available #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
May 10, 2022
| // GetConfigOrDie wraps ctrl.GetConfigOrDie and checks if the Kubernetes apiserver | ||
| // has PriorityAndFairness flow control filter enabled. If true, it returns a rest.Config | ||
| // with client side throttling disabled. Otherwise, it returns a modified rest.Config | ||
| // configured with the provided Options. | ||
| func GetConfigOrDie(opts Options) *rest.Config { |
There was a problem hiding this comment.
While working on fluxcd/helm-controller#480, I discovered this func does not have a non-panicing counterpart.
I think this would be useful to have in situations where you work with the option, but not the configuration (like the above PR).
darkowlzz
reviewed
May 11, 2022
stefanprodan
added
the
area/runtime
|
@aryan9600 please test this code with the Flux RBAC and see if we need to allow any new endpoints. Looking at the flowcontrol code seems that access to the |
|
I don't think that's the case, since only the |
|
@aryan9600 please rebase |
Checks if the PriorityAndFairness flow control filter is enabled to disable client side throttling, leveraging server side throttling instead, since client-go respects the `Retry-After` response header set by the APF filter Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
server-side-throttling
branch
from
cedb123 to
5909ab5
Compare
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if the PriorityAndFairness flow control filter is enabled to
disable client side throttling, leveraging server side throttling
instead, since client-go respects the
Retry-Afterresponse header setby the APF filter.
Fixes: #269
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com