runtime/patch: Add SerialPatcher #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
added
the
area/runtime
darkowlzz
changed the title
darkowlzz
force-pushed
the
serialpatcher
branch
from
3f1c8db
to
7e59e15
Compare
SerialPatcher is a wrapper around the patch helper to help perform consecutive patching of object in a transparent manner without the need to keep track of the object state after patching. The SerialPatcher persists the a before state of the object and a kubernetes client. The patch operations configurations aren't persisted and are accepted as argument to SerialPatcher.Patch(). This makes the patcher reusable in different scenarios during its lifetime. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
serialpatcher
branch
from
7e59e15
to
701acc8
Compare
stefanprodan
approved these changes
Oct 14, 2022
|
This looks good to me as well, thanks for taking my suggestions into account around API simplification and caller responsibilities. 🙇 |
hiddeco
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerialPatcher is a wrapper around the patch helper to help perform consecutive patching of object in a transparent manner without the need to keep track of the object state after patching.
The SerialPatcher persists a before state of the object and a kubernetes client. The patch operation configurations aren't persisted and are accepted as argument to SerialPatcher.Patch(). This makes the patcher reusable in different scenarios during its lifetime.