Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for checking out git repo to a ref #465

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Feb 13, 2023

Add a new checkout strategy that enables checking out to a Git reference: https://git-scm.com/book/en/v2/Git-Internals-Git-References. This enables users to check out to a raw reference (that doesn't necessarily point to a branch/tag).

Related to: fluxcd/source-controller#1017
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🥇

@aryan9600 aryan9600 force-pushed the clone-refname branch 2 times, most recently from 44dd196 to 2faf04a Compare February 14, 2023 09:54
@hiddeco hiddeco added enhancement New feature or request area/git Git and SSH related issues and pull requests labels Feb 14, 2023
git/libgit2/client.go Outdated Show resolved Hide resolved
@aryan9600 aryan9600 force-pushed the clone-refname branch 3 times, most recently from b4b11be to 222c469 Compare February 14, 2023 12:46
git/gogit/clone_test.go Outdated Show resolved Hide resolved
git/gogit/clone_test.go Outdated Show resolved Hide resolved
Add a new checkout strategy that enables checking out to a Git
reference: https://git-scm.com/book/en/v2/Git-Internals-Git-References.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiddeco hiddeco merged commit e8e803e into fluxcd:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git and SSH related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants