git/gogit: add proxy support for pushing to remote #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Disable CGO for Git e2e tests as it was originially required because of our libgit2 client. Since we no longer maintain a libgit2 client, there is no need to run the tests with CGO enabled. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
push-proxy
branch
2 times, most recently
from
7a58fdd to
b8a2a03
Compare
hiddeco
approved these changes
Aug 3, 2023
GitHub sometimes fails to push things using SSH due to weird and mysterious deploy key errors, like "unknown error: ERROR: Unknown public SSH key". As a workaround, the intial push operation for each test case is retried on failure for 20 seconds. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proxy support to
gogit.Client.Push().Prerequisite to: fluxcd/image-automation-controller#565