-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oci/auth: Add support for Azure China and US Gov regions #631
Conversation
e1822c2
to
d7eb4d5
Compare
514db0d
to
8611884
Compare
Signed-off-by: mihaiandreiratoiu <mihai.ratoiu@uipath.com>
8611884
to
174a5e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
But since our azure account used in CI isn't available at the moment, I'll check for a manual run of the e2e tests. Will merge after we get test results.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the oci
integration tests for Azure locally and they passed 🥳
LGTM! Thanks @mihaiandreiratoiu 🏅
This will be included in Flux 2.1.0 release, thanks @mihaiandreiratoiu PS. Could you please add UiPath to Flux adopters page https://fluxcd.io/adopters/ |
Description
When using the OCI authentication in azure with managed identity in usgovernment environment, the source-controller cannot get the permissions for the cloud because it defaults to the public azure cloud.
Error
Fix
The fix proposes a map for each azure cloud environment that is automatically detected by the suffix of the ACR.