ssa/jsondiff: cluster and desired object in Diff #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By including the objects in full, it becomes possible to for example apply the JSON Patch without having to retrieve the object again. In addition, it becomes possible to e.g. render a diff including any ignore rules (using dyff) by applying the JSON Patch to a copy of the cluster object. Note that when you want to use the JSON Patch result to perform an actual patch operation, any Secret masking should be done while displaying information and not using the available option. As otherwise the patch would be issued with masked data (and potentially illegal base64 payloads). Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By including the objects in full, it becomes possible to for example apply the JSON Patch without having to retrieve the object again.
In addition, it becomes possible to e.g. render a diff including any ignore rules (using dyff) by applying the JSON Patch to a copy of the cluster object.
Note that when you want to use the JSON Patch result to perform an actual patch operation, any Secret masking should be done while displaying information and not using the available option. As otherwise the patch would be issued with masked data (and potentially illegal base64 payloads).