-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envsubst package #758
Add envsubst package #758
Conversation
I think we should accompany this PR with an upstream PR to gomodules/envsubst to add the feature of drone/envsubst#34 so that we can remove this fork from our repo once gomodules/envsubst has been released with the feature. |
@makkes we can't do that, |
Ah, I understand. So this is meant to be a permanent fork. 👍🏻 |
Forked from https://github.com/drone/envsubst Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Incorporate drone/envsubst#34 Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR contains a fork of https://github.com/gomodules/envsubst and incorporates drone/envsubst#34.
This permanent fork is needed because envsubst powers a GA feature of Flux, and the Drone's project looks like is no longer maintained.
xref: fluxcd/flux2#4694