Update ToUnstructured to handle already unstructured case
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
update-to-unstructured
branch
from
79c0fe5 to
6f55290
Compare
|
Looks like I didn't have to actually change the argument type in the first place. |
errordeveloper
force-pushed
the
update-to-unstructured
branch
from
6f55290 to
a07182e
Compare
This version of the function is more robus, it's what is used in Timoni, updating it hear would alow avoid copies in other places. Signed-off-by: Ilya Dmitrichenko <idmitrichenko@coreweave.com>
errordeveloper
force-pushed
the
update-to-unstructured
branch
from
a07182e to
cca401b
Compare
|
@stefanprodan the intention is to make PR to Timoni and drop a copy of this function from there. I have a few other places where I used the other version. |
stefanprodan
approved these changes
Nov 21, 2024
stefanprodan
added
the
area/server-side-apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of the function is more robus, it's what is used in Timoni, updating it hear would alow avoid copies in other places.