Chore: use auto bucket lookup type

Signed-off-by: Zhiyu Wang <zhiyuwang.newbis@gmail.com>
fluxcd · Aug 31, 2023 · 1ab089e · 1ab089e
1 parent 4deb8cf
commit 1ab089e
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/minio/minio.go b/pkg/minio/minio.go
@@ -38,9 +38,11 @@ type MinioClient struct {
 // NewClient creates a new Minio storage client.
 func NewClient(bucket *sourcev1.Bucket, secret *corev1.Secret) (*MinioClient, error) {
  opt := minio.Options{
- Region: bucket.Spec.Region,
- Secure: !bucket.Spec.Insecure,
- BucketLookup: minio.BucketLookupPath,
+ Region: bucket.Spec.Region,
+ Secure: !bucket.Spec.Insecure,
+ // About BucketLookup, it should be noted that not all S3 providers support
+ // path-type access (e.g., Ali OSS). Hence, we revert to using the default
+ // auto access, which we believe can cover most use cases.
  }
 
  if secret != nil {